Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onError callback for MediaDeviceSelect #710

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Nov 14, 2023

No description provided.

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: adbc20a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/components-core Patch
@livekit/components-react Patch
@livekit/component-example-next Patch
@livekit/components-js-docs Patch
@livekit/component-docs-storybook Patch
@livekit/components-docs-gen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 14, 2023

size-limit report 📦

Path Size
LiveKitRoom only 2.1 KB (0%)
LiveKitRoom with VideoConference 30.27 KB (+0.27% 🔺)
All exports 35.65 KB (+0.22% 🔺)

@lukasIO lukasIO requested a review from Ocupe November 14, 2023 14:39
Copy link
Contributor

@Ocupe Ocupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

packages/react/src/hooks/useMediaDeviceSelect.ts Outdated Show resolved Hide resolved
@lukasIO lukasIO merged commit 2dab3b0 into main Nov 21, 2023
2 checks passed
@lukasIO lukasIO deleted the lukas/media-select-error branch November 21, 2023 16:23
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants