Report failure when WHIP handler fails to initialize #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennwc
approved these changes
Jun 26, 2024
pkg/params/params.go
Outdated
| @@ -395,6 +395,8 @@ func (p *Params) SetInputVideoStats(st *ipc.TrackStats) { | |||
| func (p *Params) SendStateUpdate(ctx context.Context) { | |||
| info := p.CopyInfo() | |||
|
|
|||
| fmt.Println("STATE UPDATE", info) | |||
There was a problem hiding this comment.
Debugging code I forgot to cleanup. Thanks.
biglittlebigben
added a commit
that referenced
this pull request
Dec 13, 2024
## Changelog ### Fixed - Log WHIP user agent and RTP packet if unmarshalling fails (#274) - Tear down full WHIP session of one of the track handlers fail (#277) - nil check on SDK teardown (#278) - Be sure to cancel input initialization when shutting down an ingress during start up (#279) - Update module golang.org/x/image to v0.18.0 [SECURITY] (#286) - Implement KillIngressSession rpc (#282) - Report failure when WHIP handler fails to initialize (#285) - Stop output sdk watchdog on teardown (#287) - Update go-gst (#305) - Update to pion/webrtc v4 (#312)
Merged
biglittlebigben
added a commit
that referenced
this pull request
Dec 13, 2024
## Changelog ### Fixed - Log WHIP user agent and RTP packet if unmarshalling fails (#274) - Tear down full WHIP session of one of the track handlers fail (#277) - nil check on SDK teardown (#278) - Be sure to cancel input initialization when shutting down an ingress during start up (#279) - Update module golang.org/x/image to v0.18.0 [SECURITY] (#286) - Implement KillIngressSession rpc (#282) - Report failure when WHIP handler fails to initialize (#285) - Stop output sdk watchdog on teardown (#287) - Update go-gst (#305) - Update to pion/webrtc v4 (#312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.