Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt v2.0 APIs #286

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Adopt v2.0 APIs #286

merged 5 commits into from
Feb 2, 2024

Conversation

davidzhao
Copy link
Member

WIP

@davidzhao
Copy link
Member Author

@dennwc I'm trying this locally and ran into a few SIP related errors. Could you take a look on this branch?

cmd/livekit-cli/sip.go:353:24: sipClient.ListSIPParticipant undefined (type *lksdk.SIPClient has no field or method ListSIPParticipant)
cmd/livekit-cli/sip.go:353:74: undefined: livekit.ListSIPParticipantRequest
cmd/livekit-cli/sip.go:377:25: sipClient.DeleteSIPParticipant undefined (type *lksdk.SIPClient has no field or method DeleteSIPParticipant)
cmd/livekit-cli/sip.go:377:77: undefined: livekit.DeleteSIPParticipantRequest
cmd/livekit-cli/sip.go:389:44: info.SipParticipantId undefined (type *livekit.SIPParticipantInfo has no field or method SipParticipantId)

@dennwc
Copy link
Contributor

dennwc commented Jan 29, 2024

@davidzhao You probably need to rebase. There's no list/delete for SIP Participant in the latest CLI.

@davidzhao
Copy link
Member Author

@davidzhao You probably need to rebase. There's no list/delete for SIP Participant in the latest CLI.

that worked, thanks!

@davidzhao davidzhao marked this pull request as ready for review January 31, 2024 06:46
dennwc
dennwc approved these changes Jan 31, 2024
View reviewed changes
go.mod Outdated
@@ -23,6 +23,8 @@ require (
gopkg.in/yaml.v3 v3.0.1
)

replace github.com/livekit/server-sdk-go => ../server-sdk-go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove it!

cmd/livekit-cli/main.go
logConfig.Level = "debug"
}
logger.InitFromConfig(logConfig, "livekit-cli")
lksdk.SetLogger(logger.GetLogger())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe switch to v2 is a good moment to use slog? It seems like uber-go/zap#1333 is not there yet, but other options like https://github.com/samber/slog-zap already exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can wait till things stabilizes a bit before updating to it

@davidzhao davidzhao merged commit a16f912 into main Feb 2, 2024
3 checks passed
@davidzhao davidzhao deleted the logging branch February 2, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennwc dennwc dennwc approved these changes

@cnderrauber cnderrauber Awaiting requested review from cnderrauber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidzhao @dennwc