Initial draft -Properly terminating when lifetime specified and has been reached #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlivekit
commented
Nov 6, 2025
| lifetimeRemaining *uint64 | ||
| } | ||
|
|
||
| func (w writeStream) String() string { |
Contributor
Author
There was a problem hiding this comment.
No clue why we're passing w writeStream by value and not by ref (w *writeStream). This is basically churning memory.
But this is why I had to do the ugly thing with the lock and *uint64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a concept draft - Not sure we want to do this now, or this way.
This would respect lifetime limits, but the user would still have to take care to re-negotiate a new key.
Ideally, that would happen some time before seeing this error.