-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict type checking #303
Conversation
🦋 Changeset detectedLatest commit: ebcfafc The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@lukasIO does this actually work for you? There aren't any automated tests on livekit-rtc, so the green check is misleading, but all of the examples fail due to issues with missing required fields at serialization as described in this issue (that I see you're already active in!) I think we might need to roll this back...
|
runtime errors 😬 will open a PR to rollback and work on fixing these. I'd prefer to merge #310 instead of the rollback, but the lack of exhaustive tests makes this slightly higher risk. |
This also fixes all errors that showed up and paves the way for more ergonomic usage by upgrading protobuf-es to v2.x (once the protovalidate types are available )