Update protocol and add SendDataRequest nonce #400
Conversation
🦋 Changeset detectedLatest commit: b54259d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Use the Web Crypto API if available, otherwise fallback to Node.js crypto |
There was a problem hiding this comment.
why not use node:crypto either way? is crypto/web more random?
There was a problem hiding this comment.
you're right, it's a bit overkill for this particular use case. Did it this way to be in line with how we're handling digest and it allows for easy removal once we drop node18 support.
relevant node docs:
> A convenient alias for crypto.webcrypto.getRandomValues(). This implementation is not compliant with the Web Crypto spec, to write web-compatible code use crypto.webcrypto.getRandomValues() instead.
No description provided.