-
Notifications
You must be signed in to change notification settings - Fork 102
add e2e tests #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e tests #591
Conversation
|
| await dispose(); | ||
| }); | ||
|
|
||
| it( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default vite only runs test files in parallel, if we want to speed the runs up we could use it.concurrent instead in order to run tests in parallel, too.
this needs config.test.maxConcurrency set as well in the vite config.
lukasIO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both remaining comments are nits and can be addressed also at a later stage.
No description provided.