Skip to content

Conversation

@davidzhao
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2026

⚠️ No Changeset found

Latest commit: 1998556

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

await dispose();
});

it(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default vite only runs test files in parallel, if we want to speed the runs up we could use it.concurrent instead in order to run tests in parallel, too.

this needs config.test.maxConcurrency set as well in the vite config.

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both remaining comments are nits and can be addressed also at a later stage.

@davidzhao davidzhao merged commit e094320 into main Jan 7, 2026
17 checks passed
@davidzhao davidzhao deleted the dz/add-test branch January 7, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants