Lk phone numbers update get #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8dd9d4a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
dennwc
reviewed
Aug 27, 2025
| // PurchasePhoneNumberRequest - Request to purchase phone numbers | ||
| message PurchasePhoneNumberRequest { | ||
| repeated string phone_numbers = 1; // Phone numbers to purchase (e.g., ["+1234567890", "+1234567891"]) | ||
| string sip_dispatch_rule_id = 2; // Optional: SIP dispatch rule ID to apply to all purchased numbers |
Contributor
There was a problem hiding this comment.
This might be misleading, since it's not linking that rule ID to the number, it's cloning the rule, right?
So to update a rule for all numbers, one would update the rule and then update numbers with that rule ID again.
Worth documenting it or adding rule id to the number model directly, if we want to link them persistently.
Contributor
Author
There was a problem hiding this comment.
It isn't meant to be a clone. I've made it consistent by using sip_dispatch_rule_id in PurchasedPhoneNumber
dennwc
approved these changes
Aug 28, 2025
Merged
This was referenced Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding update and get apis for purchased phone numbers