Adding utilities for phonenumber functionality #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nishadmusthafa
commented
Sep 11, 2025
nishadmusthafa
commented
- DB prefixes
- Helper utilities for area code and number type
1. DB prefixes 2. Helper utilities for area code and number type
🦋 Changeset detectedLatest commit: 3b51b8b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
dennwc
approved these changes
Sep 11, 2025
sip/phonenumber.go
Outdated
| } | ||
|
|
||
| // DetermineNumberType determines the phone number type using the phonenumbers library | ||
| func DetermineNumberType(phoneNumber string) string { |
There was a problem hiding this comment.
This should probably return enum of some kind. Do we have it defined in protobufs somewhere?
This was referenced Sep 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.