Skip to content

Conversation

1egoman
Copy link
Contributor

@1egoman 1egoman commented Sep 22, 2025

Per this pull request comment, add the new TokenSource request and response types into this repository so they can be encoded / decoded as snake case more elegantly in the js + swift clients, soon hopefully more.

This is the first time I've committed to this repository - I'm not sure if I put these in the right place / etc. Let me know if they should go in some other file!

@1egoman 1egoman requested a review from lukasIO September 22, 2025 21:01
Copy link

changeset-bot bot commented Sep 22, 2025

🦋 Changeset detected

Latest commit: bfc05ff

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@1egoman 1egoman requested a review from a team September 23, 2025 13:47
@1egoman
Copy link
Contributor Author

1egoman commented Sep 23, 2025

Slack comment from @lukasIO:

I would vote to move the TokenSource out of the room.proto file and either into models or into a new livekit_token_source file.
the room file is mostly concerned with signal request types that are sent between client and server.

Done - moved these messages to a new protobufs/livekit_token_source.proto file.

@1egoman
Copy link
Contributor Author

1egoman commented Sep 23, 2025

Slack comment from @lukasIO:

jfyi for the JS package build we’ll have to manually add the file also here https://github.com/livekit/protocol/tree/main/packages/javascript/src in both the index.js and d.ts file

This should be done.

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@1egoman 1egoman merged commit 0070381 into main Sep 23, 2025
7 checks passed
@1egoman 1egoman deleted the rg/add-tokensource-request-response branch September 23, 2025 17:40
@github-actions github-actions bot mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants