Skip to content

Conversation

@typester
Copy link
Contributor

No description provided.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@davidzhao davidzhao requested a review from theomonnom December 28, 2024 06:27
@typester
Copy link
Contributor Author

After reading Lukas's comment, I was also unsure during implementation whether the Python side should be made async, so I’m leaving this as an open question.

Should we await self._join_handle or self._join_fut ? If the answer is yes, I think it would be better to implement this as an async aclose and include the logic to wait for them. What do you think? @davidzhao @theomonnom

@theomonnom
Copy link
Member

theomonnom commented Dec 28, 2024

Yes please, let's create a aclose function instead, we don't need to await the join handle but it is great to keep it async to be future proof on the future changes we could do

@typester
Copy link
Contributor Author

Ok, I made it async!

@typester typester requested a review from davidzhao December 28, 2024 16:26
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@typester typester merged commit 201b04d into main Jan 2, 2025
12 checks passed
@typester typester deleted the typester/audio-video-source-close branch January 2, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants