-
Notifications
You must be signed in to change notification settings - Fork 111
Add close function to Audio|Video Source
#336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
davidzhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg!
|
After reading Lukas's comment, I was also unsure during implementation whether the Python side should be made async, so I’m leaving this as an open question. Should we await |
|
Yes please, let's create a aclose function instead, we don't need to await the join handle but it is great to keep it async to be future proof on the future changes we could do |
|
Ok, I made it async! |
davidzhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.