Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly close the room when the disconnection comes from the server #333

Merged
merged 4 commits into from
May 6, 2024

Conversation

theomonnom
Copy link
Member

No description provided.

@theomonnom theomonnom requested a review from davidzhao May 6, 2024 19:09
@theomonnom theomonnom changed the title correctly close room when disconnected from server correctly close room when the disconnection comes from the server May 6, 2024
@theomonnom theomonnom changed the title correctly close room when the disconnection comes from the server correctly close the room when the disconnection comes from the server May 6, 2024
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@theomonnom theomonnom merged commit 5085034 into main May 6, 2024
9 of 16 checks passed
@theomonnom theomonnom deleted the theo/close-fix branch May 6, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants