Skip to content

don't use clamp as the ultimate_kbps can be lower than 300 #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xianshijing-lk merged 1 commit into from
Feb 10, 2026
Merged

don't use clamp as the ultimate_kbps can be lower than 300 #886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions livekit/src/rtc_engine/peer_transport.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,13 @@ impl PeerTransport {
// JS / Flutter uses ~70% of ultimate; 100% is also reasonable per feedback.
let start_kbps = (ultimate_kbps as f64 * 0.7).round() as u32;

// Clamp: avoid silly low/high values
Some(start_kbps.clamp(300, ultimate_kbps))
// A low start-bitrate hint is more likely to hurt than help for VP9/AV1.
// If the max is too low, don't inject a start-bitrate hint at all.
if ultimate_kbps < 300 {
return None;
}

Some(start_kbps.min(ultimate_kbps))
}

fn munge_x_google_start_bitrate(sdp: &str, start_bitrate_kbps: u32) -> String {
Expand Down