Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#56 Use refine to scope monkey patch to gem only #57

Merged

Conversation

m-hukic
Copy link
Contributor

@m-hukic m-hukic commented May 7, 2024

This PR aims to replace original monkey patch causing a bug where gem is loaded before rails and then overrides the original rails #stringify_keys. It can also get in conflict with other gems using the #stringify_keys method coming from rails.

@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

@m-hukic
Copy link
Contributor Author

m-hukic commented May 7, 2024

Issue: #56

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR 🙏

@davidzhao davidzhao merged commit b950372 into livekit:main May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants