add upscale image support to AI pipelines #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliteprox
requested changes
Jun 6, 2024
There was a problem hiding this comment.
These changes look good, tested successfully. There is just one change needed to add the default containerHostPort for the new upscale pipeline.
I opened a PR to your branch to add it, please review mikezupper#4
eliteprox
approved these changes
Jun 6, 2024
rickstaa
force-pushed
the
feature/add-image-upscale
branch
from
b939673 to
1c5da15
Compare
|
@mikezupper I made some small changes and updated the code with the latest version but apart from that this pull request seems good for a merge 👍🏻. Thanks! |
This commit fixes some small bugs and improves the code formatting so that it is more in line with the other pipelines.
rickstaa
force-pushed
the
feature/add-image-upscale
branch
from
f7c5139 to
ae4f3b3
Compare
This commit ensures that the `gen_openapi.py` file also creates the OpenAPI spec for the upscaling route. It also updates the Golang client bindings.
|
@mikezupper, I noticed that this pull request did not work for me with go-livepeer. It seems you may have forgotten to add the route to the I'm very happy with the cleanliness of the implementation. This serves as an excellent example of a pull request for adding a new pipeline. 🎉 |
This commit ensures that the right client request and response types are used.
eliteprox
added a commit
to eliteprox/ai-worker
that referenced
this pull request
Jun 10, 2024
* add upscale image support using stabilityai/stable-diffusion-x4-upscaler model * Add host port for upscale pipeline * added model download to the dl_checkpoints.sh * fix: fix some small bugs and improve formatting This commit fixes some small bugs and improves the code formatting so that it is more in line with the other pipelines. * fix: ensure upscaling OpenAPI spec gets created This commit ensures that the `gen_openapi.py` file also creates the OpenAPI spec for the upscaling route. It also updates the Golang client bindings. * fix(worker): fix incorrect automatic client types This commit ensures that the right client request and response types are used. --------- Co-authored-by: Elite Encoder <john@eliteencoder.net> Co-authored-by: Rick Staa <rick.staa@outlook.com>
eliteprox
added a commit
to eliteprox/ai-worker
that referenced
this pull request
Jul 26, 2024
* add upscale image support using stabilityai/stable-diffusion-x4-upscaler model * Add host port for upscale pipeline * added model download to the dl_checkpoints.sh * fix: fix some small bugs and improve formatting This commit fixes some small bugs and improves the code formatting so that it is more in line with the other pipelines. * fix: ensure upscaling OpenAPI spec gets created This commit ensures that the `gen_openapi.py` file also creates the OpenAPI spec for the upscaling route. It also updates the Golang client bindings. * fix(worker): fix incorrect automatic client types This commit ensures that the right client request and response types are used. --------- Co-authored-by: Elite Encoder <john@eliteencoder.net> Co-authored-by: Rick Staa <rick.staa@outlook.com>
This was referenced Jul 28, 2024
This was referenced Aug 14, 2024
This was referenced Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support to upscale images using timbrooks/instruct-pix2pix model