Skip to content

Conversation

@eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Oct 7, 2025

Adds a default entrypoint and cmd to the base dockerfile for BYOC

  • Sets the default inference log level to INFO
  • Resolves issue with ComfyUI-Manager not being blacklisted due to incorrect name blacklist_nodes blacklist_custom_nodes
  • Changes default port in byoc.py from 8889 to 8000

@eliteprox eliteprox linked an issue Oct 27, 2025 that may be closed by this pull request
@eliteprox
Copy link
Collaborator Author

@pschroedl This is the first PR for comfystream to merge. It simply provides a docker entrypoint for byoc with a few small adjustments

@eliteprox eliteprox changed the title docker(byoc): add default entrypoint, fix api base path docker(byoc): add default entrypoint, set log level to INFO, fix custom node blacklist Nov 6, 2025
Copy link
Collaborator

@ad-astra-video ad-astra-video left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment would be to clear the ORCH_SECRET environment variable after pulling for registration so its not available to custom nodes.

@eliteprox
Copy link
Collaborator Author

FWIW I think registration should be a pytrickle StreamProcessor arg sent to StreamServer to run on startup. I added it in here to get things working quickly

@eliteprox
Copy link
Collaborator Author

My only comment would be to clear the ORCH_SECRET environment variable after pulling for registration so its not available to custom nodes.

Fixed in 416dc2d

Also patched one more incorrect blacklist_custom_nodes parameter 75a33c0

@eliteprox eliteprox merged commit 3014234 into main Nov 7, 2025
7 checks passed
@eliteprox eliteprox deleted the fix/byoc-registration branch November 7, 2025 17:38
@eliteprox
Copy link
Collaborator Author

Note: /bin/bash should now be executed interactively using docker run --rm -it --entrypoint /bin/bash livepeer/comfyui-base:latest -l

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BYOC Entrypoint docker container

3 participants