-
Notifications
You must be signed in to change notification settings - Fork 6
docker(byoc): add default entrypoint, set log level to INFO, fix custom node blacklist #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pschroedl This is the first PR for comfystream to merge. It simply provides a docker entrypoint for byoc with a few small adjustments |
ad-astra-video
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment would be to clear the ORCH_SECRET environment variable after pulling for registration so its not available to custom nodes.
|
FWIW I think registration should be a pytrickle StreamProcessor arg sent to StreamServer to run on startup. I added it in here to get things working quickly |
|
Note: /bin/bash should now be executed interactively using |
Adds a default entrypoint and cmd to the base dockerfile for BYOC
blacklist_nodesblacklist_custom_nodesbyoc.pyfrom 8889 to 8000