Skip to content

Conversation

@eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Oct 9, 2025

This change addresses a warning from opentelemetry-sdk package which is a dependency of comfyui:
/workspace/miniconda3/envs/comfystream/lib/python3.12/site-packages/opentelemetry/instrumentation/dependencies.py:4: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.

This is resolved in a newer version (v0.49b1) according to open-telemetry/opentelemetry-python-contrib#2871 (comment)), however ComfyUI installs the older version by default, so we should pin setuptools for now to avoid issues

Name: opentelemetry-sdk
Version: 1.27.0
Summary: OpenTelemetry Python SDK
Home-page: https://github.com/open-telemetry/opentelemetry-python/tree/main/opentelemetry-sdk
Author: 
Author-email: OpenTelemetry Authors <cncf-opentelemetry-contributors@lists.cncf.io>
License: Apache-2.0
Location: /workspace/miniconda3/envs/comfystream/lib/python3.12/site-packages
Requires: opentelemetry-api, opentelemetry-semantic-conventions, typing-extensions
Required-by: comfyui, opentelemetry-distro, opentelemetry-exporter-otlp-proto-grpc, opentelemetry-exporter-otlp-proto-http
(comfystream) root@b7f7a703be58:/workspace/comfystream# 

@eliteprox eliteprox changed the title pin setuptools < 81 to resolve opentelemetry warning pin setuptools <81 to resolve opentelemetry warning Oct 9, 2025
@eliteprox eliteprox changed the title pin setuptools <81 to resolve opentelemetry warning pin setuptools<81 to resolve opentelemetry warning Oct 9, 2025
Copy link

@JJassonn69 JJassonn69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a simple change. approving.

@eliteprox eliteprox merged commit 9ccf061 into main Nov 6, 2025
8 checks passed
@eliteprox eliteprox deleted the deps/pin-setuptools-81 branch November 6, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants