mediaserver: add useful debug info to http response headers #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emranemran
force-pushed
the
user/emahbub/add-http-debug-headers-go-livepeer
branch
from
13ade9f
to
a6a22a0
Compare
emranemran
requested review from
leszko,
RiccardoBiosas,
thomshutt,
stronk-dev,
AlexKordic and
cyberj0g
|
@emranemran Could you maybe limit the number of reviewers of this PR to 2 pers? |
emranemran
commented
Jun 9, 2022
server/mediaserver.go
Outdated
| @@ -137,11 +137,21 @@ type authWebhookResponse struct { | |||
| } | |||
|
|
|||
| func NewLivepeerServer(rtmpAddr string, lpNode *core.LivepeerNode, httpIngest bool, transcodingOptions string) (*LivepeerServer, error) { | |||
| var nodeEthAddr string = "n/a" | |||
| if lpNode.Eth != nil { | |||
| nodeEthAddr = lpNode.Eth.Account().Address.String() | |||
There was a problem hiding this comment.
@RiccardoBiosas: can you help confirm if it's OK to reveal a node's Eth Address in HTTP responses? It's marked as public in these structs so my assumption is yet but would like to confirm.
There was a problem hiding this comment.
ETH Address is public, so there are no security concerns when it comes to exposing it.
emranemran
added a commit
that referenced
this pull request
Jun 13, 2022
When viewing HLS manifests/segments, it is often useful to view information on how those segments were generated. This commit adds fields such as git-sha to the HTTP response headers. A future commit will be used to add additional debug info.
emranemran
force-pushed
the
user/emahbub/add-http-debug-headers-go-livepeer
branch
from
a6a22a0
to
199c80c
Compare
emranemran
added a commit
that referenced
this pull request
Jun 13, 2022
When viewing HLS manifests/segments, it is often useful to view information on how those segments were generated. This commit adds fields such as git-sha to the HTTP response headers. A future commit will be used to add additional debug info.
emranemran
force-pushed
the
user/emahbub/add-http-debug-headers-go-livepeer
branch
from
199c80c
to
829108a
Compare
When viewing HLS manifests/segments, it is often useful to view information on how those segments were generated. This commit adds fields such as git-sha to the HTTP response headers. A future commit will be used to add additional debug info.
emranemran
force-pushed
the
user/emahbub/add-http-debug-headers-go-livepeer
branch
from
829108a
to
baeb825
Compare
|
In its current state, this change has limited uses and the streaming workflow changes will invalidate the changes here -- we'll follow up after streaming workflow lands to achieve the requested change. |
hjpotter92
deleted the
user/emahbub/add-http-debug-headers-go-livepeer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
When viewing HLS manifests/segments, it is often useful to view information on how those segments were generated. This commit adds fields such as git-sha to the HTTP response headers.
Specific updates (required)
LPMSOptsstruct to include a newVidPlayerDebugstruct (defined in lpms repo) which holds additional parameters. These opts are used to pass useful debugging fields when instantiating aVidPlayer(to playback HLS segments).How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully[ ] All tests in./test.shpass