Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip orchestrator info requests if service uri not set by orchestrator #3149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ad-astra-video
Copy link
Collaborator

@ad-astra-video ad-astra-video commented Aug 21, 2024

What does this pull request do? Explain your changes. (required)
Update db_discovery.go to skip starting orchestrator http client if the service uri is not set by the orchestrator. At time of this commit, 71 orchestrators have not registered for the AI subnet so this skips a lot of failed http connections.

Docker build is at docker pull adastravideo/go-livepeer:ai-video-test

Specific updates (required)

  • add a check to confirm a Host exists in the parsed service uri.

How did you test each of these updates (required)
Built docker file and started up gateway
startup.log

Checklist:

@github-actions github-actions bot added the AI Issues and PR related to the AI-video branch. label Aug 21, 2024
@leszko leszko deleted the branch livepeer:master November 7, 2024 08:26
@leszko leszko closed this Nov 7, 2024
@rickstaa rickstaa reopened this Nov 13, 2024
@rickstaa rickstaa changed the base branch from ai-video to master November 13, 2024 21:49
@rickstaa
Copy link
Member

@ad-astra-video Do we still need this now that we've merged into the master branch? Are there any orchestrators that still have their service URI set to an empty string ("") by mistake? I noticed this issue once before, but I'm not sure if any orchestrators are still affected.

@ad-astra-video
Copy link
Collaborator Author

The AI service registry is still not fully used by Orchestrators. This is just a thing to ease development starting gateways faster. For production gateways it is not likely noticed much.

I have not issue closing this but it also doesn't make sense to try to connect to a URL that is blank.

@ad-astra-video
Copy link
Collaborator Author

Counted the empty entries on last test gateway startup. There are still 59 empty urls in the AIServiceRegistry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants