feat(client, overlay): Optimize frame processing during manual loading states #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g states - Updated TrickleClient to utilize this method, allowing immediate overlay frame generation without blocking the processor. - Introduced `set_loading_overlay` method in StreamProcessor to enable or disable the loading overlay for the current client, enhancing user experience during loading scenarios.
- Added a check in OverlayController to return false for overlay generation when passthrough mode is active, ensuring proper handling of manual loading states.
Collaborator
Author
|
@JJassonn69 If you have time to review today, this would be a good change to have |
… activation and refactor into cleaner subclass structure - Changed the loading overlay from automatic to manual activation during processing delays, allowing for better resource management. - Introduced a new `ModelLoadingOverlayProcessor` class to encapsulate the overlay functionality and streamline model loading and parameter updates. - Enhanced logging for model loading and processing delays, providing clearer feedback during operation.
…oving unnecessary controller references - Removed the `_current_loading_controller` method and associated controller logic, streamlining the manual overlay activation and deactivation process. - Updated the `_activate_manual_overlay` and `_disable_overlay_after` methods to directly use `set_loading_overlay`, enhancing code clarity and maintainability.
…rocessing_delay param
JJassonn69
approved these changes
Dec 9, 2025
Contributor
JJassonn69
left a comment
JJassonn69
left a comment
There was a problem hiding this comment.
Looks solid, with well tested for edge issues. Ran it locally aswell and works as expected. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
set_loading_overlayto the StreamProcessor to support toggling overlay without blocking the frame processor. This is an alternative to returningVideoProcessingResult.WITHHELDwhich involves blocking client frame processing.set_loading_overlaymethod in StreamProcessor to enable or disable the loading overlay for the current client, enhancing user experience during loading scenarios.overlay_example.pyto demonstrate non-blocking manual overlay activationThere are three ways to activate the overlay currently:
StreamServerconfigpytrickle/examples/overlay_example.py
Lines 61 to 66 in 71ff9b5
StreamProcessor.set_loading_overlay()pytrickle/pytrickle/stream_processor.py
Lines 260 to 273 in 71ff9b5
VideoProcessingResult.WITHHELD(not recommended)