Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recordtester: Use random serf memeber for playback if enabled. #234

Merged
merged 5 commits into from
Jan 3, 2023

Conversation

hjpotter92
Copy link
Member

@hjpotter92 hjpotter92 commented Dec 28, 2022

Fixes #227


Adds 3 new cli flags:

  • --serf-rpc-addr: Used to connect to serf cluster and fetch list of current members
  • --use-serf: Whether to really use serf cluster member for playback URL. Default is false.
  • --random-serf-member: Uses a random selection from serf members list for playback. Otherwise uses the first member from the list.

@hjpotter92 hjpotter92 requested a review from a team as a code owner December 28, 2022 11:37
@hjpotter92 hjpotter92 self-assigned this Dec 28, 2022
Copy link
Collaborator

@iameli iameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good (and mergeable) first step, but I think we'll want two more complex things here:

  1. "Pull count" parameter so you can pull from multiple nodes; each one will need to trigger a separate playback
  2. We'll want this to be able to geolocate so we're not unnecessarily testing pulls across the world. I guess this could be implemented with Serf tags to add the latitude and longitude parameters, and then a -max-distance parameter that limits how far the randomized Serf nodes are checked. (I guess we'll also need local -latitude and -longitude parameters to make that happen)

@hjpotter92
Copy link
Member Author

  1. "Pull count" parameter so you can pull from multiple nodes; each one will need to trigger a separate playback

added a TODO with unimplemented feature for this.

  1. We'll want this to be able to geolocate so we're not unnecessarily testing pulls across the world. I guess this could be implemented with Serf tags to add the latitude and longitude parameters, and then a -max-distance parameter that limits how far the randomized Serf nodes are checked. (I guess we'll also need local -latitude and -longitude parameters to make that happen)

sounds like a plan. let me see if i can update serf tags.


merging this PR at the current stage. will implement geolocation and pull-count once serf tags are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

record-tester: learn to download a list of nodes from Serf
2 participants