Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tester: delete asset on completion #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tester: delete asset on completion #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/app/recordtester/recordtester_app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,10 +363,13 @@ func (rt *recordTester) Start(fileName string, testDuration, pauseDuration time.
if code, err := checkPlaybackInfo(assets[0].PlaybackID, rt.lapi, lapiNoAPIKey); err != nil {
return code, err
}

rt.lapi.DeleteAsset(assets[0].ID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be a defer call earlier, before one of the above return statements?

}
glog.Infof("Done Record Test. streamId=%s playbackId=%s", stream.ID, stream.PlaybackID)

rt.lapi.DeleteStream(stream.ID)

return 0, nil
}

Expand Down
6 changes: 6 additions & 0 deletions internal/app/vodtester/vodtester_app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ func (vt *vodTester) Start(fileName string, vodImportUrl string, taskPollDuratio
return fmt.Errorf("error in export task taskId=%s: %w", exportTask.ID, err)
}

vt.Lapi.DeleteAsset(importAsset.ID)

return nil
})

Expand Down Expand Up @@ -194,6 +196,8 @@ func (vt *vodTester) directUploadTester(fileName string, taskPollDuration time.D
return fmt.Errorf("error checking playback: %w", err)
}

vt.Lapi.DeleteAsset(uploadAsset.ID)

return nil
}

Expand Down Expand Up @@ -248,6 +252,8 @@ func (vt *vodTester) resumableUploadTester(fileName string, taskPollDuration tim
return fmt.Errorf("error checking playback: %w", err)
}

vt.Lapi.DeleteAsset(uploadAsset.ID)

return nil
}

Expand Down
Loading