webhook: added last failure notification to webhook failure (#1853)

livepeer · Aug 17, 2023 · da749f0 · da749f0
1 parent 0f085ee
commit da749f0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/packages/api/src/store/messages.ts b/packages/api/src/store/messages.ts
@@ -45,6 +45,7 @@ namespace messages {
     stream?: DBStream;
     retries?: number;
     lastInterval?: number;
+    lastFailureNotification?: number;
   }
 
   export type TaskInfo = {

diff --git a/packages/api/src/webhooks/cannon.ts b/packages/api/src/webhooks/cannon.ts
@@ -245,7 +245,7 @@ export default class WebhookCannon {
         `Webhook Cannon| Max Retries Reached, id: ${trigger.id}, streamId: ${trigger.stream?.id}`
       );
       try {
-        this.notifyFailedWebhook(trigger, webhookPayload, err);
+        trigger = webhookFailNotification(trigger, webhookPayload, err);
       } catch (err) {
         console.error(
           `Webhook Cannon| Error sending notification email to user, id: ${trigger.id}, streamId: ${trigger.stream?.id}`
@@ -613,6 +613,28 @@ export async function storeTriggerStatus(
   }
 }
 
+export function webhookFailNotification(
+  trigger: messages.WebhookTrigger,
+  webhookPayload: RequestInitWithTimeout,
+  err: Error
+): messages.WebhookTrigger {
+  const lastFailureNotification = trigger?.lastFailureNotification;
+  const currentTime = Date.now();
+  if (
+    !lastFailureNotification ||
+    currentTime - lastFailureNotification > 24 * 60 * 60 * 1000
+  ) {
+    this.notifyFailedWebhook(trigger, webhookPayload, err);
+  }
+
+  trigger = {
+    ...trigger,
+    lastFailureNotification: currentTime,
+  };
+
+  return trigger;
+}
+
 export function signatureHeaders(
   payload: string,
   sharedSecret: string,