-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: stream: allow name update #2323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@victorges do you know why the stream name was immutable till now? |
@gioelecerati oh wow super weird that there's even a test. I have no idea 😅 can't think of anything that would break but now it's better to test it anyway. Maybe on the very beginning it was used for configuring streams on mist (or even wowza lol) |
Coold :D was added here #430 and I think it was just added without any specific reason, but let's test throughly either way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat
@gioelecerati lol got it. that PR has nothing to do with stream name then, probably just a confusing string i used to test the |
What does this pull request do? Explain your changes. (required)
name
as field inPATCH
stream apiSpecific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist