Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: stream: allow name update #2323

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

gioelecerati
Copy link
Member

What does this pull request do? Explain your changes. (required)

  • Allow name as field in PATCH stream api

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@gioelecerati gioelecerati requested a review from a team as a code owner October 17, 2024 15:18
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 5:27pm

@gioelecerati
Copy link
Member Author

@victorges do you know why the stream name was immutable till now?
There was also a specific test making sure it was immutable (the stream name is immutable) - is a name update going to affect anything?

@victorges
Copy link
Member

@gioelecerati oh wow super weird that there's even a test. I have no idea 😅 can't think of anything that would break but now it's better to test it anyway. Maybe on the very beginning it was used for configuring streams on mist (or even wowza lol)

@gioelecerati
Copy link
Member Author

@gioelecerati oh wow super weird that there's even a test. I have no idea 😅 can't think of anything that would break but now it's better to test it anyway. Maybe on the very beginning it was used for configuring streams on mist (or even wowza lol)

Coold :D was added here #430 and I think it was just added without any specific reason, but let's test throughly either way!

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

packages/api/src/controllers/stream.test.ts Show resolved Hide resolved
@victorges
Copy link
Member

@gioelecerati lol got it. that PR has nothing to do with stream name then, probably just a confusing string i used to test the additionalProperties validation.

@gioelecerati gioelecerati merged commit 49ac859 into master Oct 17, 2024
8 checks passed
@gioelecerati gioelecerati deleted the gio/api/allow-name-patch branch October 17, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants