chore(api): Fix yarn test script #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was one of the ways of fixing the jest issue, to avoid having test files under the dist package. It did not fix it completely because we still have a `test.js` file on the root of the package (lmk if we should remove it too) It also doesn't fix the root cause of the issue, which I found later.
This is what really fixed the test run in the end. For details: jestjs/jest#8226
Simply calls the regular test with an additional arg. This makes the root `yarn coverage` start working again, since it looks for a script with that exact name in the internal packages.
This is unrelated to the other changes but really small so I felt I could just include it here. Just what seems like a typo having the tags with inverted descriptions.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/livepeerorg/livepeer-com/3kNAx95EMBbYEbewTWrGnRzAfwRW |
|
✅ Will investigate why the build broke on github pipeline. |
I probably removed it in some of my tests and actually forgot to undo it later. This is was what was breaking the build since it tried to really run the API and didn't manage to reach the postgresql running locally.
iameli
reviewed
Jun 3, 2021
| description: User Endpoints | ||
| - name: api-token | ||
| description: Api Token Endpoints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This mainly fixes the
yarn testcommand on my machine.Took quite some while to find the real issue, but in the end it was basically this same problem:
TL;DR: the argument file sent to
jestis not actually a path but actually a regex matchedagainst the absolute file path.
Since I have all my cloned repositories under a folder like
~/workspace/src/, basically all filesinside the root folder where
jestlooks on were matching the filtered regex. This meant that alltest files on
dist/folder as well as thetest.jsin the root of theapiproject were beingexecuted as if they were tests in the project.
Specific updates
Fixed:
dist/part by ignroring.test.files on babel which I think makes sense nevertheless;test.jspart by changing thejestcommand to consider only the localsrcfolderwith
src=>${PWD}/src. This should also work on Windows as per jest docs.Tried several other options for jest like using the
--roots,--rootDirand--runTestsByPath,but all of those make the tests run really slow for some weird reason, like the actual requests
made to the test server took 100s of ms. I tried checking some configs like the DB endpoints
and fallback server but they were all fine, so I had not enough context to go further efficiently.
Also included in this change but unrelated to the main goal:
coveragescript in theapiwhich calls the test command with the additional--coverageflag, to make the root projectyarn coverageto start working again.How did you test each of these updates
Ran the related yarn scripts like
install,prepare,testandcoverageonapiandrootprojects top ensure everything was fine.
Does this pull request close any open issues?
No
Checklist