Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable thumbs for all studio vod jobs #226

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Enable thumbs for all studio vod jobs #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions task/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,22 +687,19 @@
func uploadTaskOutputLocations(tctx *TaskContext) ([]OutputName, []clients.OutputLocation, error) {
playbackId := tctx.OutputAsset.PlaybackID
outURL := tctx.OutputOSObj.URL
var mp4, thumbsEnabled string
var mp4 string

Check warning on line 690 in task/upload.go

View check run for this annotation

Codecov / codecov/patch

task/upload.go#L690 

Added line #L690 was not covered by tests
if tctx.OutputAsset.Source.Type == "recording" {
mp4 = OUTPUT_ENABLED
thumbsEnabled = OUTPUT_ENABLED
} else {
mp4 = OUTPUT_ONLY_SHORT
}
if tctx.Task.Params.Upload.Thumbnails {
thumbsEnabled = OUTPUT_ENABLED
}

outputNames, outputLocations, err := outputLocations(
outURL,
outputs{
hls: out(OUTPUT_ENABLED, playbackId),
mp4: out(mp4, playbackId),
thumbnails: out(thumbsEnabled, playbackId),
thumbnails: out(OUTPUT_ENABLED, playbackId),

Check warning on line 702 in task/upload.go

View check run for this annotation

Codecov / codecov/patch

task/upload.go#L702 

Added line #L702 was not covered by tests
},
!isEncryptionEnabled(*tctx.Task.Params.Upload),
)
Expand Down
Loading