-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CRA to 4.0.3 #98
Conversation
I wonder if there was a reason we had the version of CRA fixed? I'll try to get to testing this today. |
@dldereklee mind fixing the conflict? I assume it's just keeping your changes. |
Done |
Looks good to me! Verified locally and site builds as expected.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
building as expected. LTGM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, looks like a conflict now on the package.json. Could you please fix?
@iann Should be resolved now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you upgrade to npm
7+ and run another npm install
? I think that would reduce the number of differences on package-lock.json
and should keep the lock file version at 2.
@iann Alright regenerated it using npm 7.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #63
facebook/create-react-app#10412 (comment)