Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRA to 4.0.3 #98

Merged
merged 7 commits into from
Mar 9, 2021
Merged

Update CRA to 4.0.3 #98

merged 7 commits into from
Mar 9, 2021

Conversation

dldereklee
Copy link
Contributor

@dldereklee dldereklee commented Mar 3, 2021

Fixes #63
facebook/create-react-app#10412 (comment)

> npm audit

=== npm audit security report ===                        

found 0 vulnerabilities

@dldereklee dldereklee requested a review from livgust as a code owner March 3, 2021 02:37
@MattRC7
Copy link
Collaborator

MattRC7 commented Mar 3, 2021

I wonder if there was a reason we had the version of CRA fixed?

I'll try to get to testing this today.

@livgust
Copy link
Owner

livgust commented Mar 4, 2021

@dldereklee mind fixing the conflict? I assume it's just keeping your changes.

@dldereklee
Copy link
Contributor Author

Done

@iann
Copy link
Collaborator

iann commented Mar 5, 2021

Looks good to me! Verified locally and site builds as expected.

                       === npm audit security report ===

found 0 vulnerabilities
 in 1913 scanned packages

Copy link
Collaborator

@iann iann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building as expected. LTGM

Copy link
Collaborator

@iann iann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, looks like a conflict now on the package.json. Could you please fix?

@dldereklee
Copy link
Contributor Author

@iann Should be resolved now

@dldereklee dldereklee requested a review from iann March 7, 2021 18:45
Copy link
Collaborator

@iann iann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you upgrade to npm 7+ and run another npm install? I think that would reduce the number of differences on package-lock.json and should keep the lock file version at 2.

@dldereklee
Copy link
Contributor Author

@iann Alright regenerated it using npm 7.6.1

@dldereklee dldereklee requested a review from iann March 9, 2021 04:17
Copy link
Collaborator

@iann iann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@livgust livgust merged commit 4d17a8e into livgust:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency vulnerablity in react-scripts
5 participants