-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cron mode #19
Cron mode #19
Conversation
Hi @ErfanMomeniii , |
I think this feature offers the advantage of eliminating the need for additional tools or concepts to be periodically re-run, thereby providing users with a convenient and optional solution. |
I am not convinced that it is practical to embed cron-like feature in onedump for prod operations. The main concern is that ppl will still need the external app to recover from the failure of running onedump (e.g. when OOM happened and onedump just crashed) But I understand that there might be use cases ppl would like to experiment this tool and run it as cron job without external configuration. Having said that, if we would like to support cron-like feature, lets do it in that way. My suggestion is to use package like https://github.com/jasonlvhit/gocron to support the cron configuration. 🙏 |
Done, I also changed some arrangements of imports for having better styles. |
@ErfanMomeniii thanks so much for your contribution. Just 2 suggestion in order to merge the PR.
|
I changed the interval flag to |
@ErfanMomeniii , nice work and thanks you 🎉 |
@ErfanMomeniii btw, could you fix the pipeline error when you get a chance? |
@liweiyi88, it should be fixed now. |
I have also put a few minor comments in the PR |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 76.23% 75.35% -0.89%
==========================================
Files 19 19
Lines 968 982 +14
==========================================
+ Hits 738 740 +2
- Misses 159 170 +11
- Partials 71 72 +1
☔ View full report in Codecov by Sentry. |
I'll add some tests for increasing test coverage for each part of the project and notify you for checking that. |
Thank you @ErfanMomeniii |
Hi,
Merging this pull request can rerun jobs in a particular interval of time.
If you have any ideas or concerns regarding the PR, feel free to tell me.