Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feature that check whether http:// urls actually work using https:// #7

Merged
merged 4 commits into from
Oct 8, 2020
Merged

Conversation

hyunjiLeeTech
Copy link
Contributor

Hi Leon,

I have completed the new feature that allows users to check whether http:// urls actually work using https:// with the argument -s.

For example,
testLink -s test1.html
will check both http:// and https:// for the http:// urls.

Can you please have a look at it?

Thanks.

Add feature check whether http:// urls actually work using https://
Add feature to check whether http:// urls actually work using https://
Copy link
Owner

@lixiaoqity lixiaoqity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It is a good way to check whether http:// URLs actually work using https://.
In line 33, "data = fs.readFileSync(fileName[i++], 'utf8');", I don't think we can use i++. Because the for loop has used it.

@lixiaoqity lixiaoqity closed this Sep 30, 2020
@lixiaoqity lixiaoqity reopened this Oct 1, 2020
Fixed #6 to change the way of counting the number of files
@hyunjiLeeTech
Copy link
Contributor Author

I've fixed the thing you mention. Can you please check it?

@lixiaoqity
Copy link
Owner

I've fixed the thing you mention. Can you please check it?
Thank you for your help.

@lixiaoqity lixiaoqity closed this Oct 6, 2020
@lixiaoqity lixiaoqity reopened this Oct 8, 2020
Copy link
Owner

@lixiaoqity lixiaoqity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept the changes

@lixiaoqity lixiaoqity merged commit 0d6f19f into lixiaoqity:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants