Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use abstract GhostManager interface and also specialize on server #163

Closed
AmonGruenwald opened this issue Dec 10, 2021 · 1 comment
Closed

Use abstract GhostManager interface and also specialize on server #163

AmonGruenwald opened this issue Dec 10, 2021 · 1 comment
Assignees
@AmonGruenwald
Labels
nice to have refactor

Comments

@AmonGruenwald
Copy link
Contributor

The ClientGhostManager class extends GhostManager on the client but completely overrides a few functions because server and client handle ghosts very differently. It would be cleaner to have an abstract interface that then also gets specialized on the server, instead of having useless server functionality in the base class for the client.
@AmonGruenwald AmonGruenwald self-assigned this Dec 10, 2021
AmonGruenwald added a commit that referenced this issue Dec 16, 2021
@AmonGruenwald
Implement #163
ab2bf1e
@AmonGruenwald AmonGruenwald mentioned this issue Dec 16, 2021
Merged
@AmonGruenwald
Copy link
Contributor Author

Fixed when #173 is merged.

AmonGruenwald added a commit that referenced this issue Dec 17, 2021
@AmonGruenwald
Revert "Implement #163"
5db82d0 
This reverts commit ab2bf1e.
kb173 pushed a commit that referenced this issue Dec 17, 2021
@AmonGruenwald
Various fixes (#173)
cff0861 
* Fix #121

See godotengine/godot#27790 (comment) for reasoning.

* Fix #171

* Remove deprecated TODOs

* Implement #164

* Fix incorrect Nodepath

* Fix warnings

* Implement #163

* Revert "Implement #163"

This reverts commit ab2bf1e.

* Create GhostManagerBase.gd

* Update ClientGhostManager.gd to use base class

* Create ServerGhostManager

* Delete GhostManager.gd

* Replace _disable_signal_warnings() with explicit exception

* Turn on treat_warnings_as_errors

* Also turn on treat_warnings_as_errors for the server project

* Fix merge errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmonGruenwald AmonGruenwald

Labels
nice to have refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AmonGruenwald