You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During these corrections, there is a large lagspike on the server:
This is accompanied by a constant framerate decrease on the client:
It seems like that is caused by the MinimapIcon's pixel read for whatever reason - must be an underlying issue with the Viewport image, maybe a thread stall? d4b3ea9 commented out the MinimapIcon and it seems like that at least caused a significant improvement.
Two other take-aways from this:
The client can bombard the server with packets, stalling it and creating lagspikes for everyone (essentially a very easy DDoS attack). We need to find a way to prevent that.
The lagspike is mostly caused by the Ringbuffer. It's implemented pretty inefficiently - we could try to turn it into a static array rather than constantly dynamically resizing it, or even write a simple C++ module for it since it's so central and commonly used.
Players sometimes get corrected to positions very far away or positions that do not seem plausible.
The text was updated successfully, but these errors were encountered: