Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Settings #153

Merged
merged 4 commits into from
Dec 4, 2021
Merged

User Settings #153

merged 4 commits into from
Dec 4, 2021

Conversation

kb173
Copy link
Contributor

@kb173 kb173 commented Dec 3, 2021

Overview

The global UserSettings is responsible for keeping track of persistent user settings. Sliders, checkboxes, etc. should use UserSettings.get_setting and set_setting for setting their initial value and persisting new values. Other nodes can call UserSettings.get_setting and subscribe to UserSettings.setting_changed to react to changes.

Progress

(@incredibleLeitman @AmonShokhinAhmed @DavidPgl feel free to add ideas to this list)

image

kb173 added 2 commits December 3, 2021 17:07
2 busses (Music and Effects) were created and the AudioStreamPlayers were modified accordingly.
@kb173 kb173 marked this pull request as draft December 3, 2021 17:10
@kb173
Copy link
Contributor Author

kb173 commented Dec 3, 2021

I'd say this is ready for review+merge - the other suggested settings are likely more complex and better in separate pull requests.

@kb173 kb173 marked this pull request as ready for review December 3, 2021 20:38
Copy link
Contributor

@AmonGruenwald AmonGruenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@AmonGruenwald AmonGruenwald merged commit 946eb9c into main Dec 4, 2021
@AmonGruenwald AmonGruenwald deleted the settings branch December 4, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants