Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[New] support enumerable Symbol properties" #6

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

MartyJRE
Copy link

@MartyJRE MartyJRE commented Mar 11, 2024

This reverts commit 7d659e7.

The reason for this is that the new feature is a breaking change and should be versioned as such.

Fixes #5.

…port enumerable Symbol properties"

This partially reverts commit 7d659e7.

Co-authored-by: Martin Pražák <martin.prazak@lutherone.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A naive revert isn't the best solution here; it'd be to put the symbol part behind an option (ie, (includeSymbols ? ownEnumerableKeys : objectKeys) everywhere ownEnumerableKeys is currently called)

@MartyJRE
Copy link
Author

@ljharb I added options to traverse. It now only deals with string keys by default. When given includeSymbols: true inside the options, it functions the way you desgined.

Also added immutable to options to avoid having too many parameters.

@MartyJRE MartyJRE requested a review from ljharb March 11, 2024 22:08
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Owner

ljharb commented Mar 12, 2024

(you'll also need to rebase; i pulled out the immutable → options refactor)

@MartyJRE
Copy link
Author

@ljharb I changed the jsdocs as requested, check for the existance of higher order, otherwise, the code uses native javascript. Rebased your changes, the tests run successfully, all should be good.

@MartyJRE
Copy link
Author

The Automatic Rebase / _ / Automatic Rebase (pull_request_target) job still seems to think there are conflicts.
However, when I try to merge locally, there are no conflicts to be seen.

@MartyJRE MartyJRE requested a review from ljharb March 12, 2024 08:59
.eslintrc Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Owner

ljharb commented Mar 12, 2024

Don’t worry about the automatic rebase workflow; it’s failing because you made your PR from “main”.

@ljharb
Copy link
Owner

ljharb commented Mar 16, 2024

I've rebased this and condensed it down to one commit.

It's still failing 3 tests for me, and I'm not sure why.

@ljharb ljharb marked this pull request as draft March 16, 2024 22:03
@ljharb
Copy link
Owner

ljharb commented Apr 8, 2024

@MartyJRE are you able to complete this PR? i'd like to get the fix released.

@MartyJRE
Copy link
Author

MartyJRE commented Apr 8, 2024

@ljharb seems I accidentally added a ! in one condition, the change should be good to go now

@MartyJRE MartyJRE marked this pull request as ready for review April 8, 2024 17:58
@MartyJRE MartyJRE requested a review from ljharb April 8, 2024 17:58
@ljharb ljharb merged commit aab373f into ljharb:main Apr 8, 2024
319 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbol support breaking change
2 participants