Add proxy support

[evan-kinney]

Adds proxy support to the getJSON method.

[ljharb]

This is a lot of complexity for something that I'd expect should be largely transparent to users of this library.

What does npm itself do here for supporting proxies? What's your use case where you don't have direct access to nodejs.org?

[evan-kinney]

I agree but when your CI/CD pipelines are behind a corporate proxy what's a guy to do? NPM itself uses keys/values stored in the .npmrc file.

[evan-kinney]

I would like to add this code is a clone from the get-json library with proxy support and uses the https module instead of phin

[ljharb]

Would it make more sense to PR this support into get-json itself?

[evan-kinney]

Yes, but that library hasn't been updated in 6 years...

[ljharb]

true; i see it's now deprecated in the readme, but using fetch isn't an option for me.

why is your corporate proxy on the machine level and not the network level? could this one URL be allowlisted somehow? just trying to think of other solutions that wouldn't require this much churn.

[evan-kinney]

Our GitLab runners are all hosted as containers in AWS so the proxy is to allow connecting into certain parts of the corporate network and the internet. I believe their idea is to only allow the containers to connect when required and to block all network traffic otherwise. That way they reduce the security risk of having the network itself be routed through the proxy. I agree this is a lot of churn for what it is. I've already gotten what I need out of my fork to create a new package with proxy support for my use case but wanted to try and fold it into the main project since the work is already done.

[ljharb]

I'm now maintaining get-json, so it'd be ideal to add Proxy support there, and then this PR can be repurposed to make use of it.