Bump @npmcli/arborist and pacote
#31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade these dependencies to newer versions in order to resolve 13 deprecation warnings (some are still present due to the dependency on `get-dep-tree`, which would need to receive similar upgrades). This comes at the cost of dropping support for Node.js `^14.18` and `=16.13`. These are the minimum (major version) upgrades necessary to achieve this goal.
|
It's not worth a breaking change, and transitive deprecation warnings aren't actionable and should always be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
@npmcli/arboristandpacoteto newer versions in order to resolve 13 deprecation warnings. This comes at the cost of dropping support for Node.js^14.18and=16.13. These are the minimum (major version) upgrades necessary to achieve this goal.Note: some of the deprecation warnings are still present due to the dependency on
get-dep-tree, to resolve these too it would need to receive similar upgrades. Since you're maintaining both of these packages I figured I can start with one PR and see if you're open to upgrading 🙂