Skip to content

Commit

Permalink
[Tests] ensure windows tests install a node that actually works
Browse files Browse the repository at this point in the history
 - disable failing Alpine tests
 - disable Ubuntu-18.04 tests on node 18+
 - add Ubuntu-20.04 tests
  • Loading branch information
ljharb committed Nov 1, 2023
1 parent 1f970cc commit b64e547
Showing 1 changed file with 17 additions and 3 deletions.
20 changes: 17 additions & 3 deletions .github/workflows/windows-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,23 +99,36 @@ jobs:
matrix:
wsl-distrib:
- Debian
- Alpine
# - Alpine # fails
- Ubuntu-20.04
- Ubuntu-18.04
npm-node-version:
- '--lts'
- '21'
- '18'
- '16'
- '14'
- '12'
- '11'
- '10'
exclude:
- wsl-distrib: Ubuntu-18.04
npm-node-version: '--lts'
- wsl-distrib: Ubuntu-18.04
npm-node-version: '21'
- wsl-distrib: Ubuntu-18.04
npm-node-version: '18'
method:
- ''
- 'script'
steps:
- uses: Vampire/setup-wsl@v1
- uses: Vampire/setup-wsl@v2
with:
distribution: ${{ matrix.wsl-distrib }}
additional-packages: bash git curl ca-certificates wget
- name: Retrieve nvm on WSL
env:
C: /usr/bin/gcc-8
CXX: /usr/bin/g++-8
run: |
if [ -z "${{ matrix.method }}" ]; then
curl -fsSLo- "https://raw.githubusercontent.com/${NVM_INSTALL_GITHUB_REPO}/${NVM_INSTALL_VERSION}/install.sh" | bash
Expand All @@ -124,6 +137,7 @@ jobs:
fi
. "$HOME/.nvm/nvm.sh"
nvm install ${{ matrix.npm-node-version }}
node -v
nvm_windows:
name: 'tests, on windows'
Expand Down

0 comments on commit b64e547

Please sign in to comment.