[Refactor] remove custom ValueError in favor of TypeError

ljharb · Feb 2, 2024 · 3a0a12a · 3a0a12a
1 parent 8572ab7
commit 3a0a12a
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 15 deletions.
diff --git a/lib/parse.js b/lib/parse.js
@@ -1,7 +1,6 @@
 'use strict';
 
 var utils = require('./utils');
-var ValueError = require('./value-error');
 
 var has = Object.prototype.hasOwnProperty;
 var isArray = Array.isArray;
@@ -220,7 +219,7 @@ var normalizeParseOptions = function normalizeParseOptions(opts) {
     }
 
     if (opts.allowDots === false && opts.decodeDotInKeys === true) {
-        throw new ValueError('Provided combination is not valid: allowDots=false & decodeDotInKeys=true');
+        throw new TypeError('Provided combination is not valid: allowDots=false & decodeDotInKeys=true');
     }
 
     if (opts.decoder !== null && typeof opts.decoder !== 'undefined' && typeof opts.decoder !== 'function') {

diff --git a/lib/stringify.js b/lib/stringify.js
@@ -3,7 +3,6 @@
 var getSideChannel = require('side-channel');
 var utils = require('./utils');
 var formats = require('./formats');
-var ValueError = require('./value-error');
 var has = Object.prototype.hasOwnProperty;
 
 var arrayPrefixGenerators = {
@@ -217,7 +216,7 @@ var normalizeStringifyOptions = function normalizeStringifyOptions(opts) {
     }
 
     if (opts.allowDots === true && opts.encodeDotInKeys === false) {
-        throw new ValueError('Provided combination is not valid: allowDots=true & encodeDotInKeys=false');
+        throw new TypeError('Provided combination is not valid: allowDots=true & encodeDotInKeys=false');
     }
 
     var charset = opts.charset || defaults.charset;

diff --git a/lib/value-error.js b/lib/value-error.js
diff --git a/test/parse.js b/test/parse.js
@@ -166,7 +166,7 @@ test('parse()', function (t) {
                     { allowDots: false, decodeDotInKeys: true }
                 );
             }, {
-                name: 'ValueError',
+                name: 'TypeError',
                 message: 'Provided combination is not valid: allowDots=false & decodeDotInKeys=true'
             }
         );

diff --git a/test/stringify.js b/test/stringify.js
@@ -179,7 +179,7 @@ test('stringify()', function (t) {
                 );
             }, {
                 message: 'Provided combination is not valid: allowDots=true & encodeDotInKeys=false',
-                name: 'ValueError'
+                name: 'TypeError'
             }
         );
-Original file line number
+Diff line change
@@ Expand Up / @@ -179,7 +179,7 @@ test('stringify()', function (t) { @@
                     );
                 }, {
                     message: 'Provided combination is not valid: allowDots=true & encodeDotInKeys=false',
-                    name: 'ValueError'
+                    name: 'TypeError'
                 }
             );
@@ Expand Down @@