[Docs] add note and links for coercing primitive values #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 8 8
Lines 1385 1385
Branches 167 167
=======================================
Hits 1382 1382
Misses 3 3 Continue to review full report at Codecov.
|
ljharb
reviewed
Apr 11, 2021
README.md
Outdated
| If you wish to auto-convert values which look like numbers, booleans, and other values into their primitive values, you can do one of the following: | ||
|
|
||
| - [Install Express JS middleware to auto-convert request query parameters](https://github.com/xpepermint/query-types) | ||
| - [Copy the above MIT licensed coercion code](https://github.com/xpepermint/query-types/blob/master/index.js) directly into your project and modify it as you see fit. This code has been used on some very large projects and gives you the greatest amount of control over your data. |
There was a problem hiding this comment.
let's not advise people to copypasta code; if they want to use that code, they should depend on the package.
There was a problem hiding this comment.
Done - thanks for the feedback.
ljharb
approved these changes
Apr 18, 2021
ljharb
force-pushed
the
auto-coercion-docs
branch
from
feb3cb5 to
c2ae487
Compare
ljharb
changed the title
ljharb
pushed a commit
that referenced
this pull request
Jan 11, 2022
ljharb
pushed a commit
that referenced
this pull request
Jan 11, 2022
ljharb
pushed a commit
that referenced
this pull request
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully lay to rest #91