Fix some more escaping for .quote()

ljharb · May 20, 2016 · ace52f4 · ace52f4
1 parent 70e9eb2
commit ace52f4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/index.js b/index.js
@@ -15,7 +15,7 @@ exports.quote = function (xs) {
             return '"' + s.replace(/(["\\$`!])/g, '\\$1') + '"';
         }
         else {
-            return String(s).replace(/([\\$`()!#&*|><])/g, '\\$1');
+            return String(s).replace(/([#!"$&'()*,:;<=>?@\[\\\]^`{|}])/g, '\\$1'); 
         }
     }).join(' ');
 };

diff --git a/test/quote.js b/test/quote.js
@@ -11,16 +11,16 @@ test('quote', function (t) {
         quote([ '$', '`', '\'' ]),
         '\\$ \\` "\'"'
     );
-    t.equal(quote([]), '');
-    t.equal(quote(["a\nb"]), "'a\nb'");
-    t.equal(quote([' #(){}*|][!']), "' #(){}*|][!'");
-    t.equal(quote(["'#(){}*|][!"]), '"\'#(){}*|][\\!"');
-    t.equal(quote(["X#(){}*|][!"]), "X\\#\\(\\){}\\*\\|][\\!");
-    t.equal(quote(["a\n#\nb"]), "'a\n#\nb'");
-    t.equal(quote(['><']), '\\>\\<'); 
-    t.equal(quote([ 'a', 1, true, false ]), 'a 1 true false');
-    t.equal(quote([ 'a', 1, null, undefined ]), 'a 1 null undefined');
-    t.end();
+    t.equal(quote([]), '');                                                                                                                                                                                                                                                                                                                   
+    t.equal(quote(["a\nb"]), "'a\nb'");                                                                                                                                                                                                                                                                                                       
+    t.equal(quote([' #(){}*|][!']), "' #(){}*|][!'");                                                                                                                                                                                                                                                                                         
+    t.equal(quote(["'#(){}*|][!"]), '"\'#(){}*|][\\!"');                                                                                                                                                                                                                                                                                      
+    t.equal(quote(["X#(){}*|][!"]), "X\\#\\(\\)\\{\\}\\*\\|\\]\\[\\!");                                                                                                                                                                                                                                                                       
+    t.equal(quote(["a\n#\nb"]), "'a\n#\nb'");                                                                                                                                                                                                                                                                                                 
+    t.equal(quote(['><;{}']), '\\>\\<\\;\\{\\}');                                                                                                                                                                                                                                                                                             
+    t.equal(quote([ 'a', 1, true, false ]), 'a 1 true false');                                                                                                                                                                                                                                                                                
+    t.equal(quote([ 'a', 1, null, undefined ]), 'a 1 null undefined');                                                                                                                                                                                                                                                                        
+    t.end();  
 });
 
 test('quote ops', function (t) {