Skip to content

Commit

Permalink
Fixed typo for default service name in Jaeger Exporter (#1797)
Browse files Browse the repository at this point in the history
* Fix typo in jaeger exporter

* Update changelog

* Add PR number to changelog

* Move entry in changelog to Fixed

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
  • Loading branch information
humivo and MrAlias authored Apr 12, 2021
1 parent 95fd8f5 commit 99c477f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The Jaeger exporter now correctly records Span event's names using the `"event"` key for a tag.
Additionally, this tag is overridden, as specified in the OTel specification, if the event contains an attribute with that key. (#1768)
- Zipkin Exporter: Ensure mapping between OTel and Zipkin span data complies with the specification. (#1688)
- Fixed typo for default service name in Jaeger Exporter. (#1797)

### Changed

Expand Down
2 changes: 1 addition & 1 deletion exporters/trace/jaeger/jaeger.go
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ func process(res *resource.Resource, defaultServiceName string) *gen.Process {
// If no service.name is contained in a Span's Resource,
// that field MUST be populated from the default Resource.
if serviceName.Value.AsString() == "" {
serviceName = semconv.ServiceVersionKey.String(defaultServiceName)
serviceName = semconv.ServiceNameKey.String(defaultServiceName)
}
process.ServiceName = serviceName.Value.AsString()

Expand Down

0 comments on commit 99c477f

Please sign in to comment.