Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #154

Closed
9 tasks done
ljvmiranda921 opened this issue Jul 5, 2018 · 6 comments
Closed
9 tasks done

Documentation fixes #154

ljvmiranda921 opened this issue Jul 5, 2018 · 6 comments
Assignees
Labels
documentation Documentation improvements or fixes

Comments

@ljvmiranda921
Copy link
Owner

ljvmiranda921 commented Jul 5, 2018

Documentation Task-List

@whzup
Copy link
Collaborator

whzup commented Jul 5, 2018

I'm on the RST for Inverse Kinematics 👍.

@whzup
Copy link
Collaborator

whzup commented Jul 6, 2018

What do you think about adding PEP257 conformity, @ljvmiranda921?

@ljvmiranda921
Copy link
Owner Author

I think our numpydoc convention for the docstrings is already good 😄 I find it easier to read and parse. Although I am not sure if we are talking about the same thing. Which parts do we need PEP 257-compliance?

@whzup
Copy link
Collaborator

whzup commented Jul 6, 2018

Ok, I see. Just learned about PEP257 and thought we may use it 😄. I was especially wondering about this note:

The docstring is a phrase ending in a period. It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...".

It's the same as in the commit message subject line. I don't see the point in doing so, both variants seem fine to me but maybe you know why one would do that?

By the way, I try to make this repository more welcoming for first-timers. This has only partly to do with documentation. I found some nice sources for this to happen. Shall I open an issue where we can discuss this further?

@ljvmiranda921
Copy link
Owner Author

It's the same as in the commit message subject line. I don't see the point in doing so, both variants seem fine to me but maybe you know why one would do that?

Interesting, okay, you can add it on the checklist.

Shall I open an issue where we can discuss this further?

Hmmm... wanna discuss this first on gitter?

@whzup
Copy link
Collaborator

whzup commented Jul 12, 2018

We should run flake8 once more before release 😄. Don't know if this belongs here, though. I don't know what some things do that flake8 wants to be changed so I'd rather give this to someone who knows what he's doing there 😆.

ljvmiranda921 pushed a commit that referenced this issue Jul 25, 2018
Resolves #154 

This commit updates the PySwarms documentation from method docstrings,
examples, and guides. Please see #154
for the whole changelist.

Signed-off-by: Lester James V. Miranda <ljvmiranda@gmail.com>
Committed-with: Aaron (@whzup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements or fixes
Projects
None yet
Development

No branches or pull requests

2 participants