Hb 135 #154
Hb 135 #154
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| RequestInformation? postRequest = null; | ||
| _backendClientAdapter.SendAsync( | ||
| Arg.Do<RequestInformation>(req => postRequest = req), | ||
| Arg.Any<ParsableFactory<LoginResponse>>(), | ||
| Arg.Any<Dictionary<string, ParsableFactory<IParsable>>?>(), | ||
| Arg.Any<CancellationToken>()) | ||
| .Returns(new LoginResponse() | ||
| { |
There was a problem hiding this comment.
The IRequestAdapter.SendAsync call in these tests returns Task<LoginResponse?>, but the substitute is configured with .Returns(new LoginResponse { … }) (and .Returns((LoginResponse)null!) in the LoginAsync_WithNoResponseFromServer_Return test). Returns is strongly typed, so supplying a LoginResponse instead of a Task<LoginResponse?> is a compile-time error—the test project will not even build. These setups need to return a task (e.g. Task.FromResult<LoginResponse?>(…) or Task.FromResult<LoginResponse?>(null)), otherwise the new tests block the entire test assembly from compiling.
Useful? React with 👍 / 👎.
Updates the NUnit3TestAdapter package to the latest version.
Updates the Scalar.AspNetCore package version to the latest.
Updates the Scalar.AspNetCore package to the latest version. This ensures the application benefits from the latest features, performance improvements, and bug fixes provided by the library.
Adds several new components for editing recipe details, including description, servings, ingredients, steps, image upload, and meta information like duration and source. These components provide a structured UI for managing recipe data.
Exposes recipe description and servings as parameters. This allows the recipe servings to be dynamically set.
Refactors the UiRecipeIngredientsList and UiRecipeStepsList components to accept ingredients and steps as parameters. This change enhances the reusability and testability of these components by decoupling them from a specific recipe instance.
Refactors the recipe servings component to allow two-way binding for the number of servings. This allows the parent component to update the number of servings.
|
No description provided.