lkl: Remove CONFIG_EVENTFD in hijack init.c #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFIG_EVENTFD has been a default config Signed-off-by: Yuan Liu <liuyuan@google.com>
|
Even if CONFIG_EVENTFD is on by default, it could be changed by a custom config, so I think we should keep the ifdef. Also, since this was added by @pscollins , I want to know his opinion as well. |
|
Fine by me either way --- IIRC the problem I was trying to fix with this was better solved by adding |
|
The real problem here is that CONFIG_EVNETFD is not passed to hijack even if it's enabled. So there is no reason to keep it IMO. |
Good point. Lets remove it then. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONFIG_EVENTFD has been a default config
Signed-off-by: Yuan Liu liuyuan@google.com
This change is