new fixes for UEFI support #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@lkl-jenkins: test this please |
tavip
requested changes
Jul 10, 2017
tools/lkl/lib/virtio.c
Outdated
| @@ -549,8 +547,8 @@ int virtio_dev_setup(struct virtio_dev *dev, int queues, int num_max) | |||
|
|
|||
| if (!lkl_is_running()) { | |||
| avail = sizeof(lkl_virtio_devs) - (devs - lkl_virtio_devs); | |||
| num_bytes = snprintf(devs, avail, " virtio_mmio.device=%d@0x%"PRIxPTR":%d", | |||
| mmio_size, (uintptr_t) dev->base, dev->irq); | |||
| num_bytes = snprintf(devs, avail, " virtio_mmio.device=%d@%p:%d", | |||
There was a problem hiding this comment.
IIRC %p does not work correctly for mingw. The mingw tests seem to confirm this.
|
thanks ! please also address the checkpatch.sh error that circleci reported. |
Signed-off-by: Michael Zimmermann <sigmaepsilon92@gmail.com>
Signed-off-by: Michael Zimmermann <sigmaepsilon92@gmail.com>
Signed-off-by: Michael Zimmermann <sigmaepsilon92@gmail.com>
|
I've removed 'tools: lkl: use "%p" instead of "0x%"PRIxPTR' and added support for inttypes.h support to my libc implementation instead. |
|
@lkl-jenkins: test this please |
|
Reviewed 2 of 3 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is