Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] lkl: add arm-linux-androidabi- cross build #88

Merged
3 commits merged into from
Feb 29, 2016
Merged

[RFC] lkl: add arm-linux-androidabi- cross build #88

3 commits merged into from
Feb 29, 2016

Conversation

thehajime
Copy link
Member

please don't merge as-is

I created this patch to try to verify #59 (ARM support) on CircleCI. build test is almost okay though there are so many warnings.

I would like to ask guys for the execution test (i.e., make test) since I didn't get arm emulator running with make test so far.

this patch also includes @phhusson's #86 (comment) on gettid(), which I can't find any patch in the latest tree.

Review on Reviewable

@phhusson
Copy link

If you want to test further, some suggestions:

  1. Do a static x86 build. You should be able to run it as-is
  2. Possibly, an arm static build might be able to run in qemu-user
    Though emulator is definitely the best method, but I have no clue how to use it

@ghost
Copy link

ghost commented Feb 25, 2016

@thehajime on my machine I don't get the warnings I see in CI. This is the version installed on my machine:

Package: gcc-arm-linux-androideabi
Priority: extra
Section: universe/devel
Installed-Size: 62527
Maintainer: Dmitrijs Ledkovs xnox@ubuntu.com
Architecture: amd64
Version: 0.20130705.1-0ubuntu7

@thehajime
Copy link
Member Author

thanks @phhusson . I'm going to use the option 2 with qemu-arm.

@opurdila, the default contain of circleci is ubuntu precise (12.04), which seems not to have a package for gcc-arm-linux-androideabi and i'm using gcc in pre-installed android NDK.
now I'm trying to use beta version of trusty (14.04) container on circleci and will see how it goes.

https://discuss.circleci.com/t/ubuntu-14-04-trusty-container/2260

@thehajime thehajime force-pushed the arm-ci branch 14 times, most recently from 6d5a4b9 to d596627 Compare February 25, 2016 13:23
@thehajime
lkl tools: avoid to build hijack library and executables on arm
a314892 
but tests/boot is built.

Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
@thehajime
lkl tools: fix symbol conflict on gettid()
5fc4bd1 
Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
@thehajime
lkl: add arm-linux-androidabi- cross build
023fa73 
Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
@thehajime
Copy link
Member Author

ubuntu 14.04 container on circle ci is surely beta: apt-get update wasn't finished and failed so, we still need to 12.04 container for a while.

again, this PR introduces a test failure by segfault of make test on arm which should be fixed by the solution discussed in #59. also includes some Makefile changes to treat arm linux host like nt-host build.

I think we could taken an action:

any thought ?

@thehajime
Copy link
Member Author

again, this PR introduces a test failure by segfault of make test on arm which should be fixed by the solution discussed in #59. also includes some Makefile changes to treat arm linux host like nt-host build.

it's not true..
if we added an instance (node 2) for arm build, it will introduce a test failure by segfault.
if we kept current instances on circleci, the tests are fine.

@ngkaho1234 ngkaho1234 mentioned this pull request Feb 29, 2016
Merged
ngkaho1234 referenced this pull request Feb 29, 2016
@thehajime @ngkaho1234
lkl tools: fix symbol conflict on gettid()
b026531 
Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
ghost pushed a commit that referenced this pull request Feb 29, 2016
Merge pull request #88 from libos-nuse/arm-ci
03e3ef8 
[RFC] lkl: add arm-linux-androidabi- cross build
@ghost ghost merged commit 03e3ef8 into lkl:master Feb 29, 2016
@thehajime
Copy link
Member Author

I enabled 3rd instance of circle ci and got this:

https://circleci.com/gh/lkl/linux/289

arm build was failed and seems another reason of #59 (looks like #102 ?)
I disabled the 3rd one again.

I will investigate later and give other PRs.

@ngkaho1234 ngkaho1234 mentioned this pull request Mar 1, 2016
Merged
@thehajime
Copy link
Member Author

thanks @ngkaho1234, #109 fixes the above test issue.

@ngkaho1234
Copy link

@thehajime Probably #111 fixes this because #109 is reverted from the mainline.

@thehajime
Copy link
Member Author

@thehajime Probably #111 fixes this because #109 is reverted from the mainline.

ah, you're right. thanks @ngkaho1234.

@thehajime thehajime deleted the arm-ci branch March 8, 2016 23:02
retrage pushed a commit to retrage/linux that referenced this pull request Dec 14, 2018
@davem330
tipc: fix one byte leak in tipc_sk_set_orig_addr()
09c8b97 
sysbot/KMSAN reported an uninit-value in recvmsg() that
I tracked down to tipc_sk_set_orig_addr(), missing
srcaddr->member.scope initialization.

This patches moves srcaddr->sock.scope init to follow
fields order and ease future verifications.

BUG: KMSAN: uninit-value in copy_to_user include/linux/uaccess.h:184 [inline]
BUG: KMSAN: uninit-value in move_addr_to_user+0x32e/0x530 net/socket.c:226
CPU: 0 PID: 4549 Comm: syz-executor287 Not tainted 4.17.0-rc3+ lkl#88
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x185/0x1d0 lib/dump_stack.c:113
 kmsan_report+0x142/0x240 mm/kmsan/kmsan.c:1067
 kmsan_internal_check_memory+0x135/0x1e0 mm/kmsan/kmsan.c:1157
 kmsan_copy_to_user+0x69/0x160 mm/kmsan/kmsan.c:1199
 copy_to_user include/linux/uaccess.h:184 [inline]
 move_addr_to_user+0x32e/0x530 net/socket.c:226
 ___sys_recvmsg+0x4e2/0x810 net/socket.c:2285
 __sys_recvmsg net/socket.c:2328 [inline]
 __do_sys_recvmsg net/socket.c:2338 [inline]
 __se_sys_recvmsg net/socket.c:2335 [inline]
 __x64_sys_recvmsg+0x325/0x460 net/socket.c:2335
 do_syscall_64+0x154/0x220 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x4455e9
RSP: 002b:00007fe3bd36ddb8 EFLAGS: 00000246 ORIG_RAX: 000000000000002f
RAX: ffffffffffffffda RBX: 00000000006dac24 RCX: 00000000004455e9
RDX: 0000000000002002 RSI: 0000000020000400 RDI: 0000000000000003
RBP: 00000000006dac20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff98ce4b6f R14: 00007fe3bd36e9c0 R15: 0000000000000003

Local variable description: ----addr@___sys_recvmsg
Variable was created at:
 ___sys_recvmsg+0xd5/0x810 net/socket.c:2246
 __sys_recvmsg net/socket.c:2328 [inline]
 __do_sys_recvmsg net/socket.c:2338 [inline]
 __se_sys_recvmsg net/socket.c:2335 [inline]
 __x64_sys_recvmsg+0x325/0x460 net/socket.c:2335

Byte 19 of 32 is uninitialized

Fixes: 31c82a2 ("tipc: add second source address to recvmsg()/recvfrom()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Ying Xue <ying.xue@windriver.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thehajime @phhusson @ngkaho1234