Warn if lkl_create_syscall_thread seems unproperly used #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, just a couple of minor coding style issues - I've added some comments to the commit. |
phhusson
force-pushed
the
syscall_thread
branch
from
daa0206
to
d8ec6be
Compare
phhusson
force-pushed
the
syscall_thread
branch
from
d8ec6be
to
e7c521a
Compare
|
Since the issues I've mentioned above were trivial I've fixed them myself and merged the patch. Thanks Pierre ! |
ghost
closed this
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning to help developers realize corner cases of lkl_create_syscall_thread