Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue project review, fix minor issues #181

Merged
merged 8 commits into from
Jan 5, 2025
Merged

Continue project review, fix minor issues #181

merged 8 commits into from
Jan 5, 2025

Conversation

lkrms
Copy link
Owner

@lkrms lkrms commented Jan 3, 2025

No description provided.

lkrms added 2 commits January 3, 2025 17:38
- Fix issue where unnecessary whitespace is not removed from empty lines
  in nested heredocs
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 99.20319% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.53%. Comparing base (d5770e4) to head (953e41e).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Rule/HeredocIndentation.php 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #181   +/-   ##
=========================================
  Coverage     95.53%   95.53%           
- Complexity     2773     2791   +18     
=========================================
  Files            67       67           
  Lines          7029     7106   +77     
=========================================
+ Hits           6715     6789   +74     
- Misses          314      317    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lkrms added 4 commits January 5, 2025 11:46
- Fix issue where newlines are collapsed between close braces and
  subsequent increment or decrement operators
- Improve formatting of `for` loops with expressions that break over
  multiple lines
@lkrms lkrms changed the title Continue project review, fix nested heredoc indentation issue Continue project review, fix minor issues Jan 5, 2025
@lkrms lkrms merged commit 8fc16d9 into main Jan 5, 2025
27 checks passed
@lkrms lkrms deleted the review branch January 5, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant