Clean up documentation and code #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename for compactness: - `INFORMAL_DOC_COMMENT` -> `C_DOC_COMMENT` - `STATEMENT_TERMINATOR` -> `TERMINATOR` - `TERNARY_OPERATOR` -> `TERNARY` - `NAMED_DECLARATION` -> `DECLARATION` - `OTHER_TERNARY_OPERATOR` -> `OTHER_TERNARY` - `STRING_CLOSED_BY` -> `END_STRING` - `CHAIN_OPENED_BY` -> `CHAIN` - `NAMED_DECLARATION_PARTS` -> `DECLARATION_PARTS` - `NAMED_DECLARATION_TYPE` -> `DECLARATION_TYPE`
- Add `OperatorExceptTernaryOrDelimiter` - Replace `AltContinue` with `AltContinueOrEnd` - Remove `OpenBracketOrAlt`, `CloseBracketOrAlt`, `AltContinueWithExpression`, `AltContinueWithNoExpression`, `IfElseIfOrElse`, `OperatorTernary` `ExpressionDelimiter` - Rename other indexes for brevity or clarity
- No code changes
This will allow custom indexes like `WordPressTokenIndex` to be decoupled from `TokenIndex` so new methods remain abstract until explicitly implemented. Without this change, methods added to `TokenIndex` are silently inherited by custom indexes, which may lead to unstable behaviour.
- Extend `AbstractTokenIndex` from `WordPressTokenIndex` - Make `TokenIndex` final
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
============================================
+ Coverage 95.53% 95.84% +0.30%
- Complexity 2791 2799 +8
============================================
Files 67 67
Lines 7106 7140 +34
============================================
+ Hits 6789 6843 +54
+ Misses 317 297 -20 ☔ View full report in Codecov by Sentry. |
lkrms
force-pushed
the
cleanup
branch
7 times, most recently
from
bfc1854 to
c575c75
Compare
- Fix issue where assignments in alternative syntax constructs are not aligned when `align-data` is enabled - Fix issue where alignment is incorrectly applied to default value assignments in parameter lists with no leading newline when `align-data` is enabled - Fix issue where alternative syntax constructs may not be indented correctly when `align-lists` is enabled - Fix issue where blank lines may not be added before `yield` statements in alternative syntax constructs when `blank-before-return` is enabled - Fix issue where blank lines before and after comments are incorrectly suppressed in alternative syntax constructs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.