Improved support for github private repositories #16
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of git-deploy add a log entry with a message saying that git pull was succesfully even when git pull exited with an error code, showing no ouput as
execphp method doesn't record theSTD_ERRoutput.This MR fix that issue, raising an exception and adding git error into log. This also adds a new option to log full git output if required.
Last, the README.md contains instructions to make the user who is running the script (apache most of the cases) to trust the identity of github.com, wihtout this, is impossible to pull from a private repo on github.