Add direct client implementation #15
Conversation
|
|
||
| from llama_stack.distribution.datatypes import StackRunConfig | ||
| from llama_stack.distribution.distribution import get_provider_registry | ||
| from llama_stack.distribution.resolver import resolve_impls |
There was a problem hiding this comment.
Should we add llama-stack as a dependency for the llama-stack-client package?
There was a problem hiding this comment.
nope it should be the reverse as we talked about. this code should always be exercised when the person already has llama-stack in their environment (as a library or as pip)
There was a problem hiding this comment.
Hmm, should this class LlamaStackDirectClient be inside the llama-stack repo instead of the llama-stack-client-python repo?
-
User who want to use llama-stack as a library. Install
llama-stackpackage (dependent onllama-stack-clientpackage). Is able to useLlamaStackDirectClient. -
User who just installs
llama-stack-clientpackage. They cannot useLlamaStackDirectClientwithout installingllama-stack.
There was a problem hiding this comment.
@yanxi0830 yeah I think that makes sense to me actually.
…mastack#2930) # What does this PR do? `AgentEventLogger` only supports streaming responses, so I suggest adding a comment near the bottom of `demo_script.py` letting the user know this, e.g., if they change the `stream` value to `False` in the call to `create_turn`, they need to comment out the logging lines. See llamastack/llama-stack-client-python#15 <!-- If resolving an issue, uncomment and update the line below --> <!-- Closes #[issue-number] --> ## Test Plan <!-- Describe the tests you ran to verify your changes with result summaries. *Provide clear instructions so the plan can be easily re-executed.* --> --------- Signed-off-by: Dean Wampler <dean.wampler@ibm.com>
4 participants
The Llama Stack primarily operates as a client/server model. However, there are scenarios where hosting a distribution can be cumbersome (e.g., testing, Jupyter), making it more desirable to utilize the Llama Stack as a library.
This introduces a clever hack that extends the Stainless Python client. It intercepts GET/POST requests intended for HTTP transmission and uses reflection to deserialize and route them directly to their implementations.
Is this roundabout serialization the most efficient method? Certainly not. However, the convenience of having this as a drop-in solution is significant, and it is negligible compared to GPU latency.